A diallel set of 10 varieties of grain sorghum Sorghum bicolor (L.) Moench was studied to estimate the combining ability for yield and yield contributing traits. The sca variance was higher than gca variance for almost all the characters. Entry M-209 was better general combiner for earliness, GJ-35 for dwarfness, DMYT 231 for panicle length, DR 23, for grain yield and M-209 for stover yield. Hybrids GJ.- 36 x DR-20 and GJ-35 x DMYT-231 had high soa effect for days to 50% flowering, GJ-36 x DR-23 and GJ-35 x DMYT-231 for earliness, M-209 x DR3-1 and GJ-36 x DR-10 for dwarfness, GJ-35 x M-209 and GJ-35 x DR-10 for panicle length, GJ-36 x M-229 and M-211 x DR-10 for grain yield.